Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of headings #1465

Merged
merged 32 commits into from
Sep 18, 2024
Merged

Fix order of headings #1465

merged 32 commits into from
Sep 18, 2024

Conversation

martyav
Copy link
Contributor

@martyav martyav commented Sep 13, 2024

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.

Description

The intent of this PR is to fix some errors and warnings that might come up as we convert the files in this repo to AsciiDoc, in anticipation of the site migration to Antora. After doing a test conversion, the compiler threw 1501 errors and warnings, many of them related to section headings being out of order. A heading is considered out of order if it skips one or more heading levels -- for example, if a H1 heading (title) is followed by a section H3 heading, with no H2 in between. This is very common in certain parts of our docs.

Comments

I also fixed some spacing issues and small typos across versions of the same page.

@martyav martyav marked this pull request as ready for review September 17, 2024 18:27
@martyav
Copy link
Contributor Author

martyav commented Sep 17, 2024

Opening up for review at 31 commits, 191 files.

Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marty!

@martyav martyav merged commit c869ea6 into rancher:main Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants